Increase formula coverage. #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Code Coverage 95.93% ✅
Generated by 🚫 Danger |
Laimiux
force-pushed
the
laimonas/increase-coverage
branch
from
43418d7 to
5b0cc7b
Compare
Laimiux
commented
Sep 11, 2024
|
|
||
| private var removeListInvalidated: Boolean = false | ||
| private var scheduledForRemoval: MutableList<DeferredAction<*>>? = null | ||
| private var recomputeCheckToStartList: Boolean = false |
There was a problem hiding this comment.
Renaming these variables to have more descriptive names
Laimiux
commented
Sep 11, 2024
| } | ||
| scheduledToStart?.addAll(actionList) | ||
| for (action in actionList) { | ||
| if (!isRunning(action)) { |
There was a problem hiding this comment.
This logic was poorly written as we were potentially adding to the list twice and checking isRunning() multiple times.
Laimiux
force-pushed
the
laimonas/increase-coverage
branch
from
5b0cc7b to
905561b
Compare
Laimiux
force-pushed
the
laimonas/increase-coverage
branch
from
905561b to
4c59783
Compare
Laimiux
commented
Sep 12, 2024
| @@ -11,11 +11,11 @@ class DeferredAction<Event>( | |||
| ) { | |||
| private var cancelable: Cancelable? = null | |||
|
|
|||
| internal var listener: (Event) -> Unit = initial | |||
| internal var listener: ((Event) -> Unit)? = initial | |||
There was a problem hiding this comment.
Instead of setting empty lambda when disabling this, I made it nullable and set it to null.
Laimiux
force-pushed
the
laimonas/increase-coverage
branch
from
cd86b15 to
e912f72
Compare
deesonpatel
approved these changes
Sep 12, 2024
| observer.input(false) | ||
| observer.input(true) | ||
| observer.input(false) | ||
| observer.output { assertThat(this).isEqualTo(0) } |
There was a problem hiding this comment.
Should the output value be equal to 2?
true - state (0) + 1
false - state = 1
true - state (1) + 1
false - state = 2
There was a problem hiding this comment.
Good question, this is why the test name + comment are describing the situation
// TODO: I'm not sure if this is the right behavior
@Test
fun `action termination events are ignored`()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.